ruby-grape / grape / 28378346436

97%

master: 97%

Build Type

Pull #2773

github

Committed by ericproulx

Commit Message

Fix middleware build crash when a top-level ::Options is in scope

Grape::Middleware::Base#initialize used self.class.const_defined?(:Options),
whose default inherit: true reaches top-level constants on Object. When any
loaded gem defines a global ::Options (e.g. the `options` gem, a transitive
dependency of progress_bar), the guard returned true for every middleware
subclass, but `self.class::Options` then raised NameError because the `::`
resolution operator does not fall back to Object. This took down the whole
middleware stack for third-party middleware that does not declare its own
Options (e.g. grape_logging's RequestLogger).

Resolve the constant via a new options_const_owner helper that walks the
ancestry with const_defined?(name, false) and stops at Object, so middleware
inheritance (e.g. Versioner::Path -> Versioner::Base) keeps working without
matching unrelated globals. Apply the same fix to the DEFAULT_OPTIONS path,
which had the identical defect.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2773: Fix middleware build crash when a top-level ::Options constant is in scope

Coverage Stats

1130 of 1228 branches covered (92.02%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

3584 of 3652 relevant lines covered (98.14%)

23151.08 hits per line