NodeBB / NodeBB / 28374550310

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix: let users who can approve requests join private groups directly (#14398)

When a user self-joins a private group, they were always placed in the
pending membership queue — even when they themselves had the authority
to approve that request (group owners and global moderators). They would
then have to navigate to the group and approve their own request, which
is pointless friction.

Now, in the self-join path, if the caller can approve membership for the
group (the same check used elsewhere for group management), they are
added as a member immediately instead of being queued as pending. Users
without that authority continue to go through the normal request flow.

Coverage Stats

14068 of 19216 branches covered (73.21%)

6 of 6 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

29414 of 34442 relevant lines covered (85.4%)

3480.55 hits per line