Freegle / Iznik / 23796

72%

Build Type

push

circleci

Committed by edwh

Commit Message

fix(modtools): exclude rippled-in copies from the Edit review queue

The Edit-collection query in ListMessagesMT joined messages_edits ->
messages_groups by msgid with no rippled_in filter. A post rippled INTO a
group gains an Approved messages_groups row there (rippled_in=1), so an edit
on a rippled-in post surfaced in EVERY receiving group's Edit queue - and to
ACTIVE mods there via the all-groups (groupid=0) path - even though the edit
belongs to the post's origin group(s) only. New since rippling added the
rippled_in column (migration 2026_06_18_000004), hence "never used to be the
case". Reporter: Torbrexbones/Derek (Fife); his Loki logs show 22/23 Edit
requests on the groupid=0 path, disproving the earlier backup-mod theory.

Fix: add `AND mg.rippled_in = 0` to the Edit query's messages_groups join
only (NOT Pending - rippled-in veto-window rows are meant to show there).
Same bug class as the IP-abuse fix (4b6d7b3c3, WHERE rippled_in=0).

Regression test: origin-group mod sees the edit (all-groups + explicit
groupid); a mod active only on the rippled-into group does not, on both routes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013zGET5BRtdWbRc2nsf1Lss

Coverage Stats

10743 of 12325 branches covered (87.16%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

1334 existing lines in 40 files now uncovered.

98623 of 138807 relevant lines covered (71.05%)

41.97 hits per line