ben-manes / caffeine / #5554

100%

master: 100%

push

github

fix three jcache cache close issues and switch from revapi to roseau

- A stale CacheProxy.close() deregistered by name via destroyCache, so a
  same-named cache created concurrently could be evicted and closed. It
  now deregisters by identity (caches.remove(name, this)) through a new
  CacheManagerImpl overload; the proxy's manager reference is narrowed to
  CacheManagerImpl so the call needs no cast.

- enableManagement, enableStatistics, and (de)registerCacheEntryListener
  checked requireNotClosed() before taking the configuration monitor that
  close() tears down under, so a toggle racing close could re-register a
  JMX bean and pin the closed proxy in the MBeanServer. The check now runs
  inside the lock, matching loadAll.

- close() also ran tryClose(executor); on JDK 19+ that calls
  ExecutorService.close(), which awaits termination for up to a day and
  defeats shutdownExecutor()'s bounded shutdown. The executor is already
  shut down there, so the redundant close() is dropped.

4050 of 4056 branches covered (99.85%)

12 of 12 new or added lines in 3 files covered. (100.0%)

8246 of 8247 relevant lines covered (99.99%)

1.0 hits per line