ben-manes / caffeine / #5553

100%

master: 100%

push

github

fix the jcache provider/manager close

CacheManager.close() held its lock while calling CachingProvider.close()
to deregister, which takes the provider's manager-registry monitor; and
CachingProvider.close() takes that registry monitor and then calls
CacheManager.close() (-> the manager lock). Concurrent calls deadlock
(AB-BA).

Move the deregistration outside the manager lock: close the caches and
mark closed under the lock, then deregister from the provider unlocked
(its re-entrant manager.close() no-ops once closed). Behavior is
otherwise unchanged.

4049 of 4056 branches covered (99.83%)

11 of 11 new or added lines in 1 file covered. (100.0%)

8245 of 8246 relevant lines covered (99.99%)

1.0 hits per line