Freegle / Iznik / 23737

72%

push

circleci

fix(test): update partitionInboxData spec to the new digest-simulator contract

c49e2ba32 deliberately replaced the V1 digest model in partitionInboxData
(modtools/composables/rippling/scoring.js) with the new simulator contract:
taken posts now arrive in a separate `came_and_went` array (not via a
`successful` flag inside `selected`), and the ranked array is no longer
reordered active -> promised -> taken (it is `available` then came-and-went,
in input order). The implementation and its doc-comment were updated, but two
spec cases were not, so they kept asserting the obsolete V1 behaviour and
turned master CI red.

Update the two stale cases to the new contract:
- ranked = available (top_picks/selected + deferred) then came_and_went;
  also assert the active/promised/taken slices explicitly.
- a came_and_went post is taken (not promised) even if it still carries a
  promised flag, and must not leak into the promised slice.

Test-only change; no production behaviour change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013zGET5BRtdWbRc2nsf1Lss

11304 of 15033 branches covered (75.19%)

Branch coverage included in aggregate %.

123995 of 174447 relevant lines covered (71.08%)

37.33 hits per line