Freegle / Iznik / 23701

72%

Build Type

push

circleci

Committed by invalid-email-address

Commit Message

fix(digest): stop duplicate immediate+reach mail for scoped rippling experiment

The immediate (cursor) digest mails immediate-eligible members on arrival and
records each send in rippling_reach_notified so the reach mailer
(mailNewlyReachedForPost) skips them. That ledger write was gated on
config('freegle.ripple.enabled') alone — but the rollout runs the SCOPED
experiment (freegle.ripple.within_groups, 53 groups) with the global flag OFF.

So for scoped-experiment groups (e.g. Edinburgh) the immediate path mailed on
arrival WITHOUT recording, then the reach mailer found the same members "newly
in reach", saw nothing in the ledger, and mailed them again — ~8k duplicate
member emails/day, scaling with the rollout (168/day on 06-20 -> ~8k after the
06-24 group additions). Surfaced via Edinburgh "Bird cherry sapling" mailed
twice ~100s apart.

Fix: record in the ledger whenever rippling is active in EITHER mode (global
flag OR non-empty within_groups). When fully dark the reach mailer self-idles,
so the write is still skipped then.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aXkxBPEiPSJBaRMjz7opk

Coverage Stats

11302 of 15029 branches covered (75.2%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

123952 of 174414 relevant lines covered (71.07%)

37.25 hits per line