moonbitlang / core / 4805

91%

push

github

perf(builtin): avoid duplicate bounds check in Array::at and Array::set (#3729)

`Array::at` / `Array::set` already validate `index` with a `guard` against
`len` (and `len <= buffer length`), then index the buffer through the
checked `UninitializedArray::at` / `::set` (`_[_]`), which re-runs the same
bounds check. Use the unchecked `unsafe_get` / `unsafe_set` buffer accessors
instead, matching how `ArrayView::at` is already written.

Behavior is identical: when the guard passes, the index is always in bounds
for the buffer, so the dropped check could never have fired.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

15204 of 16672 relevant lines covered (91.19%)

189010.94 hits per line