lsm / neokai / 28280852343

71%

push

github

fix(space-runtime): activate subscribed agents for external events (#2198)

* fix: activate subscribed agents for external events

* fix: preserve activation retries and scope pre-resume to node for external events

Addresses round-4 P2 review feedback on PR #2198:

- Return target (not null) when activation times out so scheduleActivationRetry keeps retry state.

- Require an existing node execution before lazily activating a subscribed target.

- Flush older queued events before injecting the activating event.

- Scope tryResumeNodeAgentSession to the requested workflow node.

- Add tests for timeout retries, no-execution guard, and queued-event ordering.

* fix: await async flush, resume hook, and restart recovery for external-event activation

- Add flushPendingNodeQueueAsync and preparePendingNodeQueueDispatchable so activation success awaits queued deliveries before the activating event.

- Register SpaceRuntime.onSpaceResumed via SpaceManager to reschedule sessionless activation retries after a paused space resumes.

- Requeue sessionless pending deliveries as activation retries on runtime restart.

- Defend SpaceRuntime against injected spaceManager mocks missing onSpaceResumedRegister.

- Add unit tests for async flush ordering, paused-space resume, excluded retried delivery, and restart recovery.

* fix(space-runtime): unify external-event delivery with manual node activation

- Extract per-target delivery helper deliverExternalEventToWorkflowTarget so
  activation retries stay scoped to the original subscription/delivery instead
  of replaying the whole event.
- Merge the activating event into flushPendingNodeQueueAsync so it participates
  in chronological ordering with other persisted pending deliveries.
- Gate activation on run.status === 'in_progress'; keep blocked runs on the
  gate/recovery path rather than attempting activation.
- Add subscription-liveness check in the per-target helper so retries terminate
  with subscription_no_lon... (continued)

11422 of 16468 branches covered (69.36%)

Branch coverage included in aggregate %.

396 of 436 new or added lines in 3 files covered. (90.83%)

97151 of 115799 relevant lines covered (83.9%)

300.42 hits per line