moonbitlang / core / 4785

91%

push

github

perf(builtin): route StringView::at through the shared OOB helper

Follow-up to #3716 / #3717 for consistency. The other checked view accessors
(ArrayView/MutArrayView/BytesView ::at, ::set) route their out-of-bounds path
through the shared `#inline(never)` `index_out_of_bounds` helper. StringView::at
was the last `*View::at` still inlining its own `abort` call; route it through
the same helper so all four views share one helper and one message.

StringView::at already used a constant `abort("Index out of bounds")`, so it was
already inlineable (clang cost ~65) — this is a consistency change, not a perf
fix.

Behavior note: this changes StringView::at's panic text from
"Index out of bounds" to the detailed
"index out of bounds: the len is from 0 to <len> but the index is <i>",
matching the other views. No test or doc pinned the old text.

Validation:
- moon check --target all (clean)
- moon test --target native -p builtin (2835 passed), -p string (369 passed)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 of 1 new or added line in 1 file covered. (100.0%)

15167 of 16672 relevant lines covered (90.97%)

197060.97 hits per line