dangernoodle-io / TaipanMiner / 28274672749

90%

push

github

fix: ota push host isolation + unreachable-identity classification (TA-475) (#590)

* fix: classify unreadable device identity as DeviceUnreachable, not mismatch (TA-475)

- add DeviceUnreachable exception to fleetlib/safety.py (distinct from
  IdentityMismatch: board=None hostname=None means unreachable/mid-reboot,
  not a genuine safety violation)
- add _read_identity() helper to fleetlib/discovery.py returning (board,
  hostname) tuple; (None, None) means unreachable
- guard.check() now raises DeviceUnreachable when identity is unreadable,
  and IdentityMismatch only when a non-None identity genuinely differs from
  the expected board/hostname
- update all test patches from verify_identity bool to _read_identity tuple
  to match new internal seam; fix board values to match each test's guard
  expectations (esp32-wroom32, esp32-s2-mini, bitaxe-403 as appropriate)
- add TestGuardDeviceUnreachable unit tests: (a) (None,None) -> DeviceUnreachable,
  (b) differing known board -> IdentityMismatch (regression guard still fires),
  (c) matching identity -> passes

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: isolate per-host failures in ota push so one bad host doesn't abort the batch (TA-475)

- cmd_ota_push now wraps the _push() call per host in try/except; catches
  DeviceUnreachable and IdentityMismatch (print SKIPPED + continue) and
  generic Exception (print FAILED + continue) — remaining hosts are always
  attempted
- batch exit code is still non-zero when any host fails/is skipped, but
  the loop never aborts early
- cmd_call also updated to catch DeviceUnreachable alongside IdentityMismatch
  so the same fix applies to arbitrary mutating calls
- add TestCmdOtaPushHostIsolation regression tests: [healthy, unreachable,
  healthy] -> both healthy hosts pushed, unreachable skipped (SKIPPED in
  output), exit code non-zero; [healthy, identity-mismatch, healthy] ->
  same isolation behavior for IdentityMismatch

Co-Authored-By: Clau... (continued)

2887 of 3627 branches covered (79.6%)

Branch coverage included in aggregate %.

5385 of 5540 relevant lines covered (97.2%)

149095.56 hits per line