dangernoodle-io / TaipanMiner / 28249033874

90%

push

github

fix: ota push readiness grace + pending-not-failed verify; --mark-valid force (TA-457) (#582)

* fix: post-OTA readiness grace + PENDING-not-FAILED push verify (TA-457)

root cause: push() called _basic_verify() immediately after wait_for_boot()
returned (first HTTP response), with no grace for mining to spin up.
hashrate=0 at that instant caused healthy=False -> ok=False false-negative.
additionally, reset_reason='software' (expected OTA reboot) was not in
_BAD_RESET_REASONS but the instant check caught hashrate=0 before mining
resumed, producing FAILED on a fully successful push.

changes:
- add _POST_OTA_READINESS_TIMEOUT (120s) constant for post-reboot grace
- add _post_boot_verify(): always calls wait_until_ready with real timeout,
  regardless of --settle; waits for mining to spin up (hashrate>0) and heap
  to stabilise before judging health
- distinguish PENDING (healthy mining + validated:false) from real FAILED:
  reset_reason='software' after OTA reboot is expected, not a fault; only
  panic/brownout/wdt are abnormal; pending result reports ok=True, pending=True
- add _check_validated(): reads /api/health validated field; absent => assume ok
- add do_mark_valid param to push(): when True, POST mark-valid after readiness
  then confirm validated:true; default False (let firmware self-validate)
- pull() also switched to _post_boot_verify for consistency
- VerifyResult gains pending: bool field to carry PENDING state
- update test_cmd_ota.py fake_push signature for new do_mark_valid kwarg

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: --mark-valid flag for ota push (TA-457)

- add --mark-valid flag to 'ota push' subcommand (default off)
- when set, cmd_ota_push passes do_mark_valid=True to ota.push()
- cmd_ota_push prints PENDING / OK (VALIDATED) / FAILED verdicts
  matching the new pending/ok distinction from VerifyResult
- dry-run plan now mentions mark-valid intent when flag is set
- dry-run plan updated: 'firmware self-... (continued)

2886 of 3627 branches covered (79.57%)

Branch coverage included in aggregate %.

5385 of 5540 relevant lines covered (97.2%)

149095.46 hits per line