agama-project / agama / 28236489617

83%

push

github

refactor(web): color schema improvements (#3662)

## Summary

- Improve the contrast of **disabled text** in light and dark so it
meets WCAG AA without losing its muted look (the original scope of this
PR, a follow-up to #3661).
- Taking the opportunity, **rework every alert/status variant** (info,
caution, danger, success, custom) onto the SUSE brand palette, with
per-theme shades that meet WCAG AA. This fixes a genuine failure (the
stock PatternFly warning yellow hard to read on white) and removes
off-palette colors in dark (neon yellow, purple).
- Keep the existing `--agm-t--status--*--color` product hooks; only the
**defaults** change, so products can still retune any variant.
- Along the way, **fix the alert status icon**, which was undersized and
vertically misaligned against Agama's larger title.


## Motivation

This branch started as a small contrast fix for disabled text. While
verifying it against the rest of the appearance system, the alert
variants stood out: warning looked wrong in **both** themes, so we
audited all of them and folded the fix into the same PR rather than
spinning up another round-trip.

### Disabled text (original scope)

PatternFly's default disabled text fails WCAG AA 4.5:1 on Agama's
surfaces:

- **Light**: gray-40 `#a3a3a3` on white is ~2.85:1. Overridden with
`#767676` -> ~4.54:1.
- **Dark**: gray-50 `#707070` on the dark pine floating surface
(~`#0c322c`) is ~2.7:1. Overridden with `#8a8a8a` -> ~4.5:1.

Both keep the disabled appearance and remain product-overridable via
`--agm-t--text--color--disabled`.


### Alert / status variants (added scope)

How PF v6 colors an alert: the **title/body** use the regular text token
(always readable); only the **icon + accent border** take the status
color. Those are non-text, so the applicable bar is WCAG 1.4.11 (3:1),
though most variants also clear 4.5:1.

The problem: **SUSE has no yellow.** The stock PF warning `#ffcc17`
scored **1.51:1 on white** (a real failure) and look... (continued)

4887 of 6804 branches covered (71.83%)

Branch coverage included in aggregate %.

25427 of 29668 relevant lines covered (85.71%)

123.77 hits per line