Freegle / Iznik / 23552

72%

Build Type

push

circleci

Committed by edwh

Commit Message

fix(contentcheck): exclude rippled-in groups from IP-abuse check

The IP-abuse check (ContentCheckService::checkIpAbuse, "20+ different
groups" branch) joined messages_groups to messages by fromip and counted
distinct groupids without excluding rippled-in rows. Rippling-out
(ExpandService::rippleIntoNewGroups) inserts one messages_groups row per
nearby intersecting group for the SAME message, so a single post fans out
to 20-30 groups that all share the one origin message's fromip. The check
therefore flagged every rippled post as IP abuse - one member, one post,
many groups - a false positive mods could not distinguish from real abuse.

Add `WHERE messages_groups.rippled_in = 0` to both the distinct-group
count and the group-id list so only native (non-rippled) postings count.
Genuine multi-group abuse still has rippled_in=0 rows and is unaffected;
the user-count branch is untouched (it does not join messages_groups).

There are no rippled "copies" carrying the IP: fromip lives only on the
single messages row; rippling adds messages_groups rows only.

Reported: https://discourse.ilovefreegle.org/t/not-sure-if-this-is-abuse-or-rippling-out/9833

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RYd8QLaHvGnVFmtj2oLq7R

Coverage Stats

10741 of 12323 branches covered (87.16%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

123866 of 175663 relevant lines covered (70.51%)

36.91 hits per line