umputun / tg-spam / 28228265528

84%

push

github

fix: add change-ban/info buttons to reaction-spammer ban notifications (#403)

* fix(events): add change-ban/info buttons to reaction-spammer ban notifications

reaction-spammer bans were reported to the admin chat as a plain message
without action buttons, so a wrongly banned user could not be unbanned.
route the notification through a new ReportReactionBan that reuses the same
unban/info markup as ReportBan. reactions have no underlying message, so the
callback carries msgID 0 and deleteAndBan skips message deletion when it is 0.

* fix(review-loop): iteration 1 addressed 11 findings

- [major] [admin.go ReportReactionBan] move user link before "reaction spammer" so extractUsername parses the username cleanly on unban (telegram strips markdown from callback text)
- [minor] [admin.go deleteAndBan] report msgID in delete-failure error, not the admin-chat message id
- [minor] [admin.go deleteAndBan] drop "message 0 deleted" from success log when msgID is 0
- [doc-gap] [admin.go deleteAndBan] godoc notes deletion is skipped for msgID 0
- [doc-gap] [README.md] reword reaction-ban "one tap" to reflect the change-ban confirmation step
- [doc-gap] [CLAUDE.md] add Reaction Ban Notifications subsection (msgID==0 sentinel, link placement, getCleanMessage)
- [test-gap] [admin_test.go] add callbackUnbanConfirmed_reaction round-trip asserting clean approved-user name
- [test-gap] [admin_test.go] add extractUsername reaction cases (markdown + rendered) and getCleanMessage reaction shape
- [test-gap] [admin_test.go] training reaction subtest uses reaction body and asserts the confirm edit
- [test-gap] [listener_test.go] assert change-ban/info button labels, not just callback data
- [test-gap] [listener_test.go] assert ReplyMarkup on dry-run and training reaction notifications

* fix(review-loop): final cleanup pass — addressed 3 findings

- [minor] [admin.go ReportReactionBan] dry/training notifications now read "[dry run|training] would have permanently banned <li... (continued)

25 of 30 new or added lines in 2 files covered. (83.33%)

8477 of 10156 relevant lines covered (83.47%)

227.22 hits per line