moonbitlang / core / 4751

91%

Build Type

push

github

Committed by bobzhang

Commit Message

refactor(json): drop redundant control-char checks in lex_string

Two checks named '\n'/'\r' explicitly even though the general
control-char guard already covers them:

- Fast path: `c == '\n' || c == '\r' || c < ' '` is just `c < ' '`,
  since '\n' (0x0A) and '\r' (0x0D) are both below ' ' (0x20).
- Slow path: the `Some('\n' | '\r') => invalid_char(shift=-1)` arm is
  subsumed by the catch-all `Some(ch) => if ch.to_int() < 32 { ... }`.

Collapse both to the single control-char check. Add a slow-path
regression test (raw newline after a valid '\t' escape) since that
branch was previously only reached via the now-removed explicit arm.

Pure refactor, no behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

15151 of 16656 relevant lines covered (90.96%)

197437.53 hits per line