microlinkhq / browserless / 28223422624

84%

push

github

fix(capture): apply device viewport before recording starts (#804)

Tab capture pins exact width/height from the target device, so
`getUserMedia` overconstrains and fails with OverconstrainedError when
the page still has the browser's default viewport. `resolveViewport`
computed the device viewport but never applied it before the extension
mode started recording.

Rename to `prepareViewport` and `page.setViewport(device.viewport)`
before any mode starts, so the page always matches the constraints.
Navigation still runs after recording starts, so load animations are
captured from t=0. This centralizes the viewport application for all
modes, making the frame recorder's own setViewport redundant.

Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

572 of 677 branches covered (84.49%)

Branch coverage included in aggregate %.

13 of 16 new or added lines in 2 files covered. (81.25%)

2979 of 3436 relevant lines covered (86.7%)

145821.27 hits per line