nbari / pg_exporter / 28222625222

91%

main: 91%

Build Type

push

github

Committed by nbari

Commit Message

fix(devpod): make `just test` pass in the devcontainer

Three issues surfaced running the suite inside the compose devcontainer:

- pgbench missing: on Debian/PGDG the pgbench binary ships in the server package
  (postgresql-NN), not postgresql-client-NN, so `postgresql-client` alone left a
  wrapper with no backing binary ("You must install at least one
  postgresql-client-<version> package"). Add scripts/install-postgres-client.sh
  which adds the PGDG repo, disables auto local-cluster creation, and installs the
  matching client + server package for psql + pgbench 18; mise task calls it.

- localhost-only test guard: tests/common/get_test_dsn refused any non-localhost
  DSN. The devcontainer's DB is a trusted compose sibling reached as `postgres`,
  so add an explicit PG_EXPORTER_TEST_ALLOW_NONLOCAL opt-in (set in
  .devcontainer/compose.yaml); the guard stays strict everywhere else.

- hardcoded DSNs: two tests in tests/exporter.rs connected to
  localhost:5432 directly instead of common::get_test_dsn(), timing out against
  the postgres service. Use the helper (the intentional db-down test keeps its
  bad-port DSN).

Coverage Stats

6 of 9 new or added lines in 2 files covered. (66.67%)

4 existing lines in 2 files now uncovered.

11139 of 12356 relevant lines covered (90.15%)

83.88 hits per line