kobotoolbox / kpi / 28219835057

81%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

feat(subsequences): add `pendingReview` flag to `_supplementalDetails` for unaccepted NLP results DEV-2333 (#7182)

### 📣 Summary
Updates the data output transformation for the
`/api/v2/assets/{asset-uid}/data` endpoint to surface a `pendingReview:
true` flag in `_supplementalDetails` when a transcription or translation
is completed but awaiting manual acceptance.

### 📖 Description
Previously, the endpoint only returned data if it had a `_dateAccepted`
timestamp. Because of this, the frontend couldn't detect when an
automatic transcription was finished and ready for review.

Additionally, this fixes a precedence issue: if a user generated a new
auto-transcription on top of an older, accepted manual transcription,
the API would still serve the old manual version. Now, the newest action
takes precedence, accurately surfacing the pending review status so the
UI can display the "Review" button.

What changed:
- Updated `transform_data_for_output` within the transcription and
translation mixins.
- The data endpoint now evaluates the most recently created version of
an action, rather than just the most recently accepted one.
- If the latest version lacks a `_dateAccepted`, the API returns
`pendingReview: True` and omits the text value.
- Retained the check to ensure that if the latest version is deleted
(where value is explicitly None), it correctly returns an empty object.

Coverage Stats

9086 of 12572 branches covered (72.27%)

0 of 29 new or added lines in 1 file covered. (0.0%)

5 existing lines in 2 files now uncovered.

29793 of 37051 relevant lines covered (80.41%)

5.52 hits per line