kobotoolbox / kpi / 28195029459

81%

master: 76%

push

github

refactor(massEmails): simplify inactive/active user queries DEV-2271 (#7170)

### 📣 Summary

Internal only — no user-visible change.

### 👷 Description for instance maintainers

Builds on #7167 (adds `ExtraUserDetail.last_project_activity`) and
simplifies the mass email and Django admin user activity queries to use
that field directly, replacing the previous multi-table queries on
`Instance` and `Asset` that could time out on large deployments.

The `get_inactive_users` and `get_active_users` functions now each issue
a single query using `last_project_activity`, which is kept up to date
automatically on every submission, submission edit, asset creation, and
asset modification, for both the actor and the form owner.

### 💭 Notes

- `get_users_with_recent_activity()` removed — its logic is now a single
`Q(extra_details__last_project_activity__gt=...)` filter inlined into
each caller
- `get_inactive_users` / `get_active_users` now issue two DB queries
instead of four, with no Python-side set materialisation
- `InactiveUsersAsOfFilter` (Django admin) passes the QuerySet directly
instead of calling `.values_list('pk', flat=True)` first
- Depends on #7167 being merged into `release/2.026.25` first

9091 of 12382 branches covered (73.42%)

0 of 4 new or added lines in 2 files covered. (0.0%)

29844 of 36689 relevant lines covered (81.34%)

5.54 hits per line