Freegle / Iznik / 23475

71%

master: 72%

Pull #899

circleci

fix(message): use LastInsertId for new message id, not SELECT max-id

PutMessage created a message then read its id back with
"SELECT id FROM messages WHERE fromuser=? ORDER BY id DESC LIMIT 1". With the
read/write split (MYSQL_HOST_READ set) that SELECT is routed to a replica, which
under Galera's cross-node apply window had not yet applied the just-done INSERT -
so it returned the user's PREVIOUS message id. The new message's draft, its
photos (UPDATE messages_attachments SET msgid=newMsgID) and the subsequent
JoinAndPost then all bound to that old post, grafting a new offer onto an
existing one and merging the photos (Discourse 9832 "mixed up offers").

Read the id from the INSERT's own LastInsertId on the write connection
(db.DB() returns the source even with dbresolver registered), matching the
pattern in CreateGroup. The freshly-inserted message is then used for everything
downstream.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SwyetpbkbQV4AWWdqkBcvv

11282 of 15003 branches covered (75.2%)

Branch coverage included in aggregate %.

7 of 9 new or added lines in 1 file covered. (77.78%)

123765 of 174136 relevant lines covered (71.07%)

37.31 hits per line