vocdoni / saas-backend / 28188283899

63%

push

github

fix(api): resolve election metadata from a stored reference on GET /process/{id} (#553)

* fix(api): resolve election metadata from a stored reference on GET /process/{id}

The Vochain node only resolves ipfs:// metadata pointers, so the https
/storage pointer this service publishes is never resolved downstream and the
election metadata goes missing.

Store a generic reference (Process.MetadataURL) and resolve it on read:
- our own object storage (matched first, works even when serverURL is empty) ->
  read locally;
- ipfs:// -> resolve via the Vochain, then cache locally and promote the
  reference so later reads stay local;
- other http(s) -> best-effort external fetch (3s timeout, 1 MiB cap).

The reference is bootstrapped from the on-chain pointer when missing (covers
pre-existing/external processes, no migration). Resolution is best-effort: any
error logs and returns the stored value. Drafts (no on-chain address) keep
their stored metadata map.

* fix(api): cache externally-fetched metadata too, not just ipfs

Metadata is immutable (a change is a republish through this API), so the
external http(s) case is as safe to cache as ipfs. Unify both remote branches:
any remotely-resolved document is stored locally and the reference promoted, so
later reads resolve from our own storage with no external/Vochain round-trip.

* fix(api): address Copilot review on metadata resolution

- match relative /storage/ references and trim a trailing slash from serverURL
  so local resolution survives a serverURL change/misconfig. This lives in
  objectstorage (Client.LocalName / Client.LocalURL) so URL parse+format stay
  with the storage layer, not the api package.
- persist the promoted reference with a targeted SetProcessMetadataURL ($set
  metadataURL only) instead of a full SetProcess rewrite, so the read path can't
  clobber concurrent updates to other process fields.
- add tests: fetchExternalMetadata (ok/non-200/over-cap) and the remote->local
  cache+promot... (continued)

91 of 119 new or added lines in 4 files covered. (76.47%)

9909 of 15930 relevant lines covered (62.2%)

44.47 hits per line