MushroomObserver / mushroom-observer / 28183491215

98%

main: 98%

Build Type

Pull #4594

github

Committed by nimmolo

Commit Message

Address Copilot review: default collapsed: true, fix aria-controls, size_class

- Change default `collapsed:` from false to true in both Link::CollapseToggle
  and Button::CollapseToggle — nearly every caller starts with the pane hidden;
  callers where the pane starts open now pass `collapsed: false` explicitly
  (api_keys/form.rb cancel buttons, form/search.rb bar toggle)
- Drop now-redundant `collapsed: true` from callers that relied on the old
  explicit kwarg: search_bar.rb, api_keys/table.rb, contributors/legend.rb,
  form/location_map.rb
- Fix field_with_help.rb and help/collapse_info_trigger.rb: previously rendered
  aria-expanded="true" on initially-collapsed help triggers; fixed by the
  default change with no per-caller edit required
- Omit aria-controls when target_id is blank (Panel uses CSS class selectors
  as collapse_target, leaving target_id empty — empty idrefs are invalid ARIA)
- Delegate size_class to Components::Button::Styling.size_class for consistent
  validation across Button and Link
- Update stale hook comments: Button::Toggle → Button::CollapseToggle

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #4594: Add Link::CollapseToggle; sweep hand-rolled collapse triggers

Coverage Stats

81 of 82 new or added lines in 20 files covered. (98.78%)

1 existing line in 1 file now uncovered.

49681 of 50495 relevant lines covered (98.39%)

732.39 hits per line