dcdpr / jp / 28170221208

69%

push

github

fix(cli, printer): Fix missing/extra blank lines around tool output (#795)

Previously, tool call headers, custom argument blocks, and results
managed their own trailing newlines independently, leading to missing
blank lines between a tool result and the next tool header, or double
blank lines when visible assistant content followed a result.

A new lazy separator mechanism replaces the hardcoded trailing `\n\n`
writes. After a tool result or custom argument block renders, a shared
`AtomicBool` flag is raised to signal that the next tool call header
owes a blank line above it. The separator is emitted just before the
header (or temp line) and cleared immediately. Visible assistant content
arriving between two tool calls clears the flag without emitting the
blank line, since it supplies its own spacing. Hidden reasoning, which
renders nothing, leaves the flag untouched so the debt survives.

The `TurnView` is wired to the same flag so streaming turns (via
`turn_loop`) and replay turns (via `TurnRenderer`) both benefit. A new
`ErrChannel` wrapper in `jp_printer` enforces at compile-time that
chrome renderers write only to stderr, replacing the previous
`Arc<Printer>` pattern in `ToolRenderer`.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

75 of 80 new or added lines in 7 files covered. (93.75%)

36511 of 54490 relevant lines covered (67.0%)

403.01 hits per line