28169807954
98%
main: 98%

Ran 25 Jun 2026 12:27PM UTC

Jobs 1

Files 1670

Run time 3min

Badge

Embed ▾

Committed 25 Jun 2026 12:23PM UTC coverage: 98.387%. Remained the same

Build # 28169807954

Build Type

Pull #4600

github

Committed by

JoeCohen

Commit Message

Fix nil observation_id in add_missing_views_corresponding_to_votes

The unqualified SELECT :observation_id was ambiguous when joined with
observation_views, which also has an observation_id column. For rows
matched by WHERE observation_views.id IS NULL, MySQL resolved the
ambiguity to `observation_views.observation_id (NULL)`, producing log
lines like "User 4468 has reviewed observation  (insert)." and writing
nil observation_id into new ObservationView records.

When you write .select(:observation_id), ActiveRecord generates SQL like:

```sql
SELECT observation_id, user_id, updated_at FROM votes LEFT OUTER JOIN observation_views ON ...
```
Both votes and observation_views have an observation_id column, so observation_id in the SELECT list is ambiguous — MySQL has to pick one.

The fix generates:
```sql
SELECT votes.observation_id, votes.user_id, votes.updated_at FROM votes LEFT OUTER JOIN observation_views ON ...
```

Pull Request Pull Request #4600: Fix nil observation_id in add_missing_views_corresponding_to_votes

Coverage Stats

49653 of 50467 relevant lines covered (98.39%)

726.5 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	28169807954.1	25 Jun 2026 12:27PM UTC	1670	98.39	GitHub Action Run

MushroomObserver / mushroom-observer / 28169807954
98%
main: 98%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 28169807954

MushroomObserver / mushroom-observer / 28169807954 98% main: 98%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 28169807954

MushroomObserver / mushroom-observer / 28169807954
98%
main: 98%

README BADGES
x