Freegle / Iznik / 23308

76%

push

circleci

fix(jobs): stop logging content-free job-click hits (jobid=0/link='')

POST /job from bots/scanners carries neither an id nor a link, yet RecordJobClick still
INSERTed a row — so logs_jobs filled with ~99% jobid=0/link='' noise that buries the genuine
clicks (and made the table useless as a click signal, e.g. when diagnosing the billable-click
drop). A real click always carries at least a job id (web app JSON body) or a link (digest
email query param), so skip the insert when both are absent. Still returns success so callers
see no error. Regression test: TestJobClick_ContentFree asserts no row is written; the
JSON-body and query/form paths (real clicks) are unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PfxahVbxhqzd9XWp2ptA7R

11221 of 14914 branches covered (75.24%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

123084 of 173550 relevant lines covered (70.92%)

37.31 hits per line