lsm / neokai / 28134967932

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: guard activation pending flush with run deliverability check (#2172)

collectPersistedPendingDeliveries (the activation-time persisted pending
external delivery flush, invoked from flushPendingNodeQueue) dispatched
persisted rows without verifying the workflow run is externally
deliverable. This mirrors requeuePersistedPendingDeliveries (the rehydrate
path): before dispatching, compute run deliverability with
blocked-with-active-execution semantics and otherwise mark the delivery
failed terminal with run_not_externally_deliverable, updating event
terminal state.

The run state is computed once before the loop since all deliveries here
share target.workflowRunId.

Coverage Stats

11361 of 16393 branches covered (69.3%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

95309 of 113564 relevant lines covered (83.93%)

300.36 hits per line