lsm / neokai / 28133958326

82%

push

github

fix: guard concurrent flush from double-dispatching persisted deliveries (#2174)

* fix: guard concurrent flush from double-dispatching persisted deliveries

flushPendingNodeQueue can be called concurrently for the same target when a
worker activates (e.g. spawn + recovery paths). The DB-persisted pending
delivery flush re-reads the same rows each call. The immediate dispatch path
already claims the delivery synchronously via deliverToSession's
externalEventDeliveriesInFlight add, but the rate-limit digest path deferred
that claim until the setTimeout(0) callback ran — opening a window where a
second flush re-selected the same persisted rows from the DB and pushed them
into the digest again, producing duplicate injections.

Claim the delivery key in externalEventDeliveriesInFlight synchronously in the
digest path of enqueueDeliverableExternalEvent (before the timer fires), so the
existing in-flight check in collectPersistedPendingDeliveries blocks the
re-selection. Release the claim in the digest session-loss requeue path and on
stop() so requeued/stopped deliveries are not stranded across the claim window.

Adds a regression test that publishes >10 events (overflow into the digest
path) and asserts two back-to-back flush calls yield a digest covering the 2
overflowed events once — not 4.

* fix: release digest-path claim when purging auto-PR digest items

The synchronous in-flight claim added to the rate-limit digest path also
needs to be released in purgeAutoPrDigestItemsForRun, which drops buffered
auto-PR digest items when clearPrEventSubscriptionsForRun runs (gate opens /
run unblocks). Without the release, clearing an auto-PR subscription while
events are buffered in the digest leaks the delivery key in
externalEventDeliveriesInFlight.

Adds a regression test: >10 auto-PR events overflow into the digest, then
clearing the subscription must release the in-flight claim for the purged
items (verified the test fails without the release).

Addresses ... (continued)

11362 of 16393 branches covered (69.31%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

95257 of 113534 relevant lines covered (83.9%)

300.34 hits per line