reactivando / use-pubsub-js / 28131737072

100%

master: 80%

push

github

feat!: brand SubscriptionToken so unsubscribe rejects arbitrary strings (#84)

subscribe/subscribeOnce now return a branded `SubscriptionToken` (a string at
runtime). `unsubscribe` accepts only that token or a handler reference, so
passing an arbitrary string — e.g. a topic name by mistake — is a compile error.
`Token` is kept as a deprecated alias; the hook's internal token ref is typed
accordingly. Build-enforced; runtime behavior unchanged (107 tests, 100% cov).

The broader "unified PubSubInterface" idea from the audit was dropped after
empirically verifying it cannot remove the createPubSub cast (generic method
variance makes the loose impl unassignable to a strict generic interface, and
`keyof E` admits `number` which violates the key constraint). Branding is the
high-value, low-risk half.

BREAKING CHANGE: `subscribe`/`subscribeOnce` return `SubscriptionToken` (branded)
instead of a plain string; code that stored the token as `string` and passed it
to `unsubscribe` must type it as `SubscriptionToken`.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

26 of 26 branches covered (100.0%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

167 of 167 relevant lines covered (100.0%)

36.35 hits per line