decentraland / decentraland-gatsby / 28124693452

56%

push

github

fix: release timed-out response bodies in API.fetch (#1326)

* fix: release timed-out response bodies in API.fetch

When `API.fetch` races the request against its timeout, a slow request can
still settle with a real `Response` after the timeout has already won the race
and returned the fallback / 408. That response's body was never read, so its
underlying socket stayed checked out of the connection pool and its buffered
bytes stayed on the heap until GC — the same non-cancelled-request leak fixed
in @dcl/fetch-component.

The in-flight request is now kept and, when the timeout wins, its body is
released with `response.body?.cancel()`. This is a no-op when the fetch rejected
on abort, and works with the native fetch of both the browser and Node, so the
race is preserved for custom `setFetcher()` fetchers that may not honour abort.

* chore: bump @dcl/http-server to 2.1.0

Moves the lockfile from the pinned 2.0.1 to the current latest 2.1.0 (and pulls
@dcl/core-commons 0.10.1 along with it), picking up the request hot-path work in
the http-server component used by the WKC ExpressContext.

504 of 1110 branches covered (45.41%)

Branch coverage included in aggregate %.

6 of 7 new or added lines in 1 file covered. (85.71%)

1262 of 2045 relevant lines covered (61.71%)

11.63 hits per line