decentraland / lamb2 / 28123678469

62%

Build Type

push

github

Committed by web-flow

Commit Message

fix: cancel undrained response bodies and bump @dcl core-components/core-libs deps (#468)

* fix: cancel undrained response bodies and bump @dcl core-components/core-libs deps

Cancel HTTP response bodies on non-OK paths that previously discarded the
Response without reading or cancelling it, leaking the pooled socket /
buffered bytes:

- alchemy-nft-fetcher (getNFTsForOwnerForNetwork): error-status path
- entities-fetcher (fetchCollectionPagination): 404 and other non-OK paths
- marketplace-api-fetcher (makeApiRequest): thrown-error path
- status (LRUCache fetchMethod): non-OK path
- third-party-collections-cache-warmer (isContentServerReady): non-OK path

Each discard path now runs `await response.body?.cancel().catch(() => undefined)`
before returning/throwing. The injected fetch is native (undici) whose
Response.body is a WHATWG ReadableStream with a real cancel().

Bump @dcl core-components/core-libs dependencies to latest:
- @dcl/crypto ^3.4.5 -> ^3.7.0
- @dcl/http-server ^2.0.1 -> ^2.1.0
- @dcl/http-tracer-component ^2.0.0 -> ^2.0.1
- @dcl/schema-validator-component ^1.0.0 -> ^1.0.1
- @dcl/thegraph-component ^0.1.0 -> ^0.1.2
- @dcl/traced-fetch-component ^1.0.6 -> ^1.0.8
- @dcl/urn-resolver ^3.6.0 -> ^3.6.1

@dcl/crypto 3.7.0 tightened computeAddress to require a 64-byte or
0x04-prefixed 65-byte key; update the generateRandomAddress test helper to
pass an uncompressed public key so it keeps working.

* chore: bump dcl-catalyst-client to v22 to drop node-fetch

v22 replaced its cross-fetch/@well-known-components/fetch-component
dependencies (which transitively pulled node-fetch@2) with
@dcl/fetch-component (native fetch). The createContentClient call and
ContentClient type import remain source-compatible, so no code changes
are required.

Coverage Stats

720 of 962 branches covered (74.84%)

Branch coverage included in aggregate %.

3 of 9 new or added lines in 5 files covered. (33.33%)

3 existing lines in 3 files now uncovered.

2034 of 2353 relevant lines covered (86.44%)

47.56 hits per line