ultimate-notion / ultimate-notion / 28111085830

87%

push

github

Add ty type checker to CI (#237)

* Add ty type checker to CI

Wire Astral's `ty` into the `lint` hatch env alongside mypy so it runs as
part of `hatch run lint:all` (and thus in CI). Existing diagnostics are
suppressed with rule-specific inline `# ty: ignore[...]` comments, with two
mypy-overlap rules (`unused-type-ignore-comment`, `redundant-cast`) disabled
via `[tool.ty]` config since they clash with suppressions/casts mypy needs.

Also fix a real bug ty surfaced: `Session.__exit__` typed its parameters as
non-optional, but Python passes `None` for all three on a clean exit, so the
context-manager protocol was not correctly implemented.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Bump ty to 0.0.51 and reduce ty ignores

Bump the pinned ty to 0.0.51 and drop the redundant `[tool.ty.environment]
python-version` (ty infers it from `requires-python`).

Remove ~70 `# ty: ignore` suppressions by fixing the underlying issues
rather than masking them:

- query.py: declare the per-subclass dispatch constants (`_condition_kw`,
  `_num_condition_kw`, `_date_condition_kw`) as `ClassVar`, so ty no longer
  treats them as required init params.
- query.py / google tasks client: add a small `_build()` helper to localize
  the genuinely-dynamic pydantic construction (`Model(**dynamic_kwargs)`),
  which ty cannot verify without a pydantic plugin.
- obj_api/endpoints.py: qualify `list[...]` annotations as `builtins.list[...]`
  where a sibling `list()` method shadows the builtin.
- blocks.py / props.py: narrow `Block | Sequence[Block]` via an
  explicitly-typed local instead of reassigning the parameter.
- raise_unset call sites: narrow with `if is_unset(x := ...): raise_unset(x)`
  (mypy and ty resolve the overloaded helper's union return differently).
- session.py: fix the genuinely-wrong `Session.__exit__` signature
  (parameters are `None` on a clean exit).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Narro... (continued)

11 of 11 new or added lines in 2 files covered. (100.0%)

6610 of 7521 relevant lines covered (87.89%)

6.12 hits per line