supabase / supabase-flutter / 28103817248

85%

push

github

refactor(storage_client): dedupe retry assertion and fetch options (#1462)

## What

Two pieces of repetition in `StorageFileApi` (`storage_file_api.dart`):

- The `assert(retryAttempts == null || retryAttempts >= 0, ...)` check
was duplicated across 6 methods → extracted into
`_assertValidRetryAttempts`.
- `FetchOptions(headers: headers)` was constructed in 13 places →
extracted into a `_fetchOptions` getter.

No behavior change. `FetchOptions` is immutable (all-final, `const`
constructor) and the `options` value is never mutated, so the getter is
semantically identical to the previous per-call construction.

## Verification

- `dart analyze lib` and `dcm analyze` pass with no issues.
- All storage_client unit tests pass. (The integration tests fail
locally only because they need a running storage server: `Connection
refused`.)

---
**Note:** This branch also removes two stale
`avoid-unnecessary-type-assertions` ignores in `postgrest_builder.dart`.
They are flagged as unused by the DCM version used in CI (a pre-existing
failure on `main`, present on every PR). Including it keeps this PR's
pipeline green; it drops out cleanly once another PR carrying the same
fix lands.

22 of 22 new or added lines in 1 file covered. (100.0%)

4096 of 4809 relevant lines covered (85.17%)

3.62 hits per line