28103817248
92%

Ran 24 Jun 2026 01:58PM UTC

Jobs 8

Files 80

Run time 1min

Badge

Embed ▾

Committed 24 Jun 2026 01:56PM UTC coverage: 85.174% (-0.006%) from 85.18%

Build # 28103817248

Build Type

push

github

Committed by

web-flow

Commit Message

refactor(storage_client): dedupe retry assertion and fetch options (#1462)

## What

Two pieces of repetition in `StorageFileApi` (`storage_file_api.dart`):

- The `assert(retryAttempts == null || retryAttempts >= 0, ...)` check
was duplicated across 6 methods → extracted into
`_assertValidRetryAttempts`.
- `FetchOptions(headers: headers)` was constructed in 13 places →
extracted into a `_fetchOptions` getter.

No behavior change. `FetchOptions` is immutable (all-final, `const`
constructor) and the `options` value is never mutated, so the getter is
semantically identical to the previous per-call construction.

## Verification

- `dart analyze lib` and `dcm analyze` pass with no issues.
- All storage_client unit tests pass. (The integration tests fail
locally only because they need a running storage server: `Connection
refused`.)

---
**Note:** This branch also removes two stale
`avoid-unnecessary-type-assertions` ignores in `postgrest_builder.dart`.
They are flagged as unused by the DCM version used in CI (a pre-existing
failure on `main`, present on every PR). Including it keeps this PR's
pipeline green; it drops out cleanly once another PR carrying the same
fix lands.

Coverage Stats

4096 of 4809 relevant lines covered (85.17%)

3.62 hits per line

Coverage Regressions

Lines	Coverage	∆	File
1	99.4	0.01%	packages/storage_client/lib/src/storage_file_api.dart

Jobs

ID	Job ID	Ran	Files	Coverage
6	supabase - 28103817248.6	24 Jun 2026 01:58PM UTC	15	82.03	GitHub Action Run
7	storage_client - 28103817248.7	24 Jun 2026 01:59PM UTC	5	92.97	GitHub Action Run
8	supabase_flutter - 28103817248.8	24 Jun 2026 01:59PM UTC	11	77.52	GitHub Action Run
6	gotrue - 27986095786.6	22 Jun 2026 09:48PM UTC	26	83.52	GitHub Action Run
5	postgrest - 27986095786.5	22 Jun 2026 09:47PM UTC	9	84.03	GitHub Action Run
7	yet_another_json_isolate - 27986095786.7	22 Jun 2026 09:45PM UTC	1	79.03	GitHub Action Run
6	realtime_client - 28101310897.6	24 Jun 2026 01:20PM UTC	11	88.1	GitHub Action Run
4	functions_client - 27986095786.4	22 Jun 2026 09:45PM UTC	2	97.14	GitHub Action Run

supabase / supabase-flutter / 28103817248
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28103817248

supabase / supabase-flutter / 28103817248 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28103817248

supabase / supabase-flutter / 28103817248
92%

README BADGES
x