supabase / supabase-flutter / 28101310897

85%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(realtime_client): extract broadcast headers and body builders (#1461)

## What

`httpSend()` and the REST fallback inside `send()` built identical
broadcast request headers and near-identical message bodies. This
extracts the duplication into:

- `Map<String, String> get _broadcastHeaders`
- `Map<String, dynamic> _broadcastBody(String? event, Map<String,
dynamic> payload)`

Both call sites now use these helpers.

## Notes

- No behavior change. The two body literals previously differed only in
key order (`event`/`payload`), which is irrelevant for JSON encoding.
- The `// ignore: avoid-inferrable-type-arguments` comments are no
longer needed since the map literal type is now inferred from the
getter's return type.

## Verification

- `dart analyze lib` and `dcm analyze` pass with no issues.
- All realtime_client unit tests pass. (The integration test fails
locally only because it needs a running realtime server: `Connection
refused`.)

---
**Note:** This branch also includes a one-line removal of two stale
`avoid-unnecessary-type-assertions` ignores in `postgrest_builder.dart`.
They are flagged as unused by the DCM version used in CI (a pre-existing
failure on `main`, present on every PR). Including it here keeps this
PR's pipeline green; it can drop out cleanly once another PR carrying
the same fix lands.

Coverage Stats

16 of 16 new or added lines in 1 file covered. (100.0%)

13 existing lines in 1 file now uncovered.

4098 of 4811 relevant lines covered (85.18%)

3.62 hits per line