stacklok / toolhive / 28101234055
67%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 763
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.17% (+0.05%) from 67.123%
28101234055

push

github

web-flow 
Document level-triggered operator reconciliation rules (#5609)

* Document level-triggered operator reconcile rules

The operator rules file covered CRD conventions and status/spec patching
mechanics but said nothing about the reconciliation principles those
mechanics serve. Add the governing rule — a reconciler is an idempotent,
level-triggered function from observed state to desired state — plus
supporting rules for errors/requeue, status and conditions, ownership
and finalizers, API hygiene and concurrency, scale and event plumbing,
validation, and manager bootstrap.

Each rule was verified against the actual cmd/thv-operator code, cites a
real exemplar, and notes the codebase's tolerated exceptions so the
rules apply without over-flagging conformant patterns.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Correct operator-rule inaccuracies from review

Address review findings against the actual cmd/thv-operator code:

- conditions.go holds only the shared Valid/DeletionBlocked types;
  per-CRD condition types live in their *_types.go files. Reword so the
  rule doesn't push CRD-specific types into the shared file.
- The Helm chart passes --leader-elect unconditionally, not gated on
  replicaCount; describe actual behaviour and warn against "fixing" it
  into a default-off conditional.
- The only leader-only runnable is a usage/update-check worker
  (pkg/operator/telemetry), not an OTEL metrics emitter; state the
  operator exposes no custom domain metrics today.
- Prefix the GC helper packages with cmd/thv-operator/.
- Replace the non-actionable "belt-and-suspenders, not mandatory"
  predicate note with a default-plus-reason (do not add it).
- Add a note that file pointers are illustrations accurate as of the
  last edit and the structural pattern is authoritative, so "do not
  copy"/"being migrated" markers don't rot into false claims.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Fix codespell... (continued)

69668 of 103719 relevant lines covered (67.17%)

65.74 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
76.15
 -5.5% pkg/secrets/keyring/keyctl_linux.go
6
66.87
 4.57% pkg/workloads/manager.go
3
64.29
 -4.29% pkg/state/runconfig.go
2
96.47
 0.0% pkg/authserver/storage/memory.go
Jobs
ID Job ID Ran Files Coverage
1 28101234055.1 763
67.17
 GitHub Action Run
Source Files on build 28101234055