stacklok / toolhive / 28099346748

67%

Build Type

push

github

Committed by web-flow

Commit Message

Index MCPOIDCConfig referencing-workload lookups (#5608)

* Index MCPOIDCConfig referencing-workload lookups

findReferencingWorkloads rebuilt the MCPOIDCConfig reference list — on every
reconcile and on every deletion check — by listing all MCPServers,
VirtualMCPServers, and MCPRemoteProxies in the namespace and filtering them in
memory. That is O(all workloads) and scales poorly as a namespace fills up.

Register field indexes on the three workloads' oidcConfigRef fields and query
them with client.MatchingFields, so each lookup returns only the workloads that
actually reference the config. This mirrors the existing spec.groupRef indexes
(setupGroupRefFieldIndexes, mcpserverentry_controller) and is registered in
SetupWithManager, so it applies in production and the integration suite alike.

Behavior is unchanged — the computed reference list is identical, just produced
by an indexed lookup instead of a full in-memory scan. This is the template for
the same change across the other config controllers (see #5607).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Add reverse-reference controller conventions to operator rules

Codify the field-indexer + level-triggered reverse-reference pattern (and the
anti-patterns it replaces) so future controller code does not regress to
list-all-and-filter lookups, hand-rolled stale-ref scans, or unnecessary
denormalized reference lists in status. Auto-loads on cmd/thv-operator/**.

See #5607 / #5608 for the worked example.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

19 of 56 new or added lines in 1 file covered. (33.93%)

70 existing lines in 4 files now uncovered.

69619 of 103719 relevant lines covered (67.12%)

66.26 hits per line