iotaledger / iota / 28069178327
67%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1108
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.464% (+0.006%) from 67.458%
28069178327

push

github

web-flow 
feat(iota-move-natives): add protocol_config::get_attr<T> native for reading protocol parameters in Move. (#11951)

# Description of change

Adds a generic `get_attr<T>` native function to the
`iota::protocol_config` framework module, extending the existing
is_feature_enabled API to cover numeric and boolean protocol parameters
(not just feature flags, but config protocol params).

This PR fills the remaining gap: reading u16, u32, u64, and bool config
parameters by name. The native delegates to the auto-generated
ProtocolConfig::lookup_attr accessor and wraps the result in T, abort
when:
- the parameter is absent at the current protocol version (deprecated or
not yet introduced),
- the requested type T does not match the parameter's actual type.

## Links to any relevant issues

Fixes #11884.

## How the change has been tested

Six new Move unit tests in protocol_config_tests.move cover:

- Some(u64) read (max_tx_size_bytes)
- Some(u32) read (max_arguments)
- Some(u16) read (binary_module_handles)

### Release Notes

- [x] Protocol: Added get_attr<T: copy + drop + store>(param_name:
vector<u8>): T to the iota::protocol_config framework module (protocol
version 30).
- [ ] Nodes (Validators and Full nodes):
- [ ] Indexer:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
- [ ] gRPC:

35 of 36 new or added lines in 3 files covered. (97.22%)

734 existing lines in 17 files now uncovered.

158494 of 234932 relevant lines covered (67.46%)

466244.84 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
89.36
 7.54% iota-execution/latest/iota-move-natives/src/protocol_config.rs

Coverage Regressions

Lines Coverage ∆ File
592
5.61
 5.61% crates/iota-indexer/src/read.rs
52
0.0
 0.0% crates/iota-data-ingestion/src/main.rs
34
89.34
 -2.18% crates/iota-protocol-config/src/lib.rs
20
60.13
 -13.07% external-crates/move/crates/move-package/src/resolution/dependency_cache.rs
10
0.0
 0.0% crates/iota-indexer/src/apis/read_api.rs
9
66.67
 -18.75% crates/iota-network-stack/src/anemo_ext.rs
4
90.59
 -0.47% crates/iota-network/src/state_sync/mod.rs
2
91.15
 -0.08% crates/iota-core/src/authority/authority_per_epoch_store.rs
2
89.03
 -0.27% crates/iota-network/src/discovery/mod.rs
2
88.85
 -0.22% crates/starfish/core/src/commit_syncer/fast.rs
1
65.38
 -1.28% crates/iota-config/src/persisted_config.rs
1
73.3
 -0.18% crates/iota-core/src/authority_server/validator.rs
1
98.62
 -0.28% crates/iota-core/src/signature_verifier.rs
1
30.12
 -1.2% crates/iota-json-rpc/src/logger.rs
1
95.65
 -4.35% crates/iota-keys/src/random_names.rs
1
83.45
 -0.24% crates/starfish/core/src/core_thread.rs
1
91.88
 0.28% crates/starfish/core/src/header_synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 28069178327.1 1108
67.46
 GitHub Action Run
Source Files on build 28069178327