stacklok / toolhive / 28058076167

67%

Build Type

push

github

Committed by web-flow

Commit Message

Route server.New through core.New and Serve (#5556)

* Route server.New through core.New and Serve

server.New was the vMCP transport god-object: a ~210-line constructor that
inlined the mcp-go server, SDK hooks, two-phase session creation, the workflow
composer, telemetry decoration, and the health monitor. Phases 1-2 extracted a
stateless domain core (core.New) and a transport entry point (Serve) behind a
stable seam, but server.New still ran the legacy inline path. This reduces
server.New to the thin wrapper the RFC specifies, making New/Serve the single
live path for every caller.

What changed:
- server.New now builds the health monitor at the composition root (A2),
  assembles the core via core.New(deriveCoreConfig(...)) and hands it to
  Serve(deriveServerConfig(...)). The 7-param signature is unchanged.
- server.Config gains Aggregator and Authz fields (the only channel to feed the
  core under the frozen signature); cli/serve.go sets them, and a new
  authfactory.BuildAuthzConfig surfaces the *authz.Config the HTTP middleware is
  built from so the core admission seam enforces the same policy.
- Elicitation's construction-order inversion (the SDK adapter wraps the mcp-go
  server Serve builds) is resolved with a late-bound requester bound after Serve.
- The session factory config sets AdvertiseFromCore so the core is the single
  aggregator and the Serve-layer optimizer (not the factory decorator) advertises
  find_tool/call_tool.
- Removed New's //nolint:gocyclo, the dead validateWorkflows, and the now-orphaned
  router/backendClient/handlerFactory/capabilityAdapter Server fields.
- Reworked the server parity suite to exercise the core path: tools are sourced
  from a stub/real Aggregator and calls route through core.CallTool.

Rebased onto #5561, which landed the prerequisites this reroute depends on:
composite-tool workflow telemetry now lives in the core (core_telemetry.go's
telemetryComposer), and passthrough-header forwarding on the Ser... (continued)

Coverage Stats

175 of 208 new or added lines in 9 files covered. (84.13%)

105 existing lines in 11 files now uncovered.

69548 of 103575 relevant lines covered (67.15%)

65.71 hits per line