stacklok / toolhive / 28057876341

67%

Build Type

push

github

Committed by web-flow

Commit Message

Add global Redis default config support to operator (#5595)

* Add defaultRedis config block to operator chart values

* Inject TOOLHIVE_DEFAULT_REDIS_ADDR env var from operator.defaultRedis / global.redis

* Add helm-unittest suite for TOOLHIVE_DEFAULT_REDIS_ADDR env var injection

* Fix existingSecretKey default to allow global.redis.existingSecretKey to propagate

When operator.defaultRedis.existingSecretKey was set to "redis-password",
the Helm default filter would always use this value, preventing
global.redis.existingSecretKey from propagating. Change to empty string
so the template fallback logic works correctly: operator local value,
then global.redis.existingSecretKey, then "redis-password" default.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Add ReadDefaultRedisConfig helper to read TOOLHIVE_DEFAULT_REDIS_ADDR from env

* Fall back to TOOLHIVE_DEFAULT_REDIS_ADDR for MCPServer session storage when spec unset

* Fall back to TOOLHIVE_DEFAULT_REDIS_ADDR for MCPRemoteProxy session storage when spec unset

* Fall back to TOOLHIVE_DEFAULT_REDIS_ADDR for VirtualMCPServer session storage and password

* Prevent global Redis default from overriding explicit non-Redis session storage providers

A CR that explicitly sets spec.sessionStorage to a non-Redis provider
(e.g. "memory") was incorrectly falling through to pick up the global
TOOLHIVE_DEFAULT_REDIS_ADDR/secret defaults in both
populateScalingConfigForRemoteProxy and buildRedisPasswordEnvVar. The fix
adds an early return whenever spec.sessionStorage is non-nil, so the
global default is only consulted when the operator field is absent.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Update helm-docs for operator.defaultRedis values

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

62 of 66 new or added lines in 5 files covered. (93.94%)

21 existing lines in 5 files now uncovered.

69637 of 103656 relevant lines covered (67.18%)

65.67 hits per line