agama-project / agama / 28025224739

83%

push

github

fix: avoid calls to YaST software modules (#3649)

After the changes introduced by
https://github.com/agama-project/agama/commit/908d17fe5,
the Agama D-Bus service is using again the *YaST software modules*
(e.g., `Yast::Package`) to check whether a package is available in the
repositories. But software is now configured by *agama-software* (rust
service) instead of YaST, so calling YaST to check for the availability
of the packages would report wrong results. Moreover, calling to YaST
software takes the libzypp lock, so it prevents the usage of *zypper* in
the live image, see https://bugzilla.suse.com/show_bug.cgi?id=1268344.

Furthermore, the D-Bus service currently checks the availability of
optional packages beforehand, so an optional package is requested to be
installed only if it is available. But this approach has some drawbacks:

* The availability of a package cannot be checked until a product is
selected or registered.
* The availability of a package might not be realliable if there was any
network issue while reading the repositories.

This PR solves these problems by avoiding to check the availability of
the packages. Now, all the packages are supposed to be available, but a
package can be requested as optional. As result, *agama-software* will
install the optional package only if it is available, achieving the same
result as before without the need of checking for the availability of
packages in advance.

There is a especial treatement for the *os-prober* package, as it is
documented in the code.

Requires https://github.com/yast/yast-storage-ng/pull/1430

4795 of 6689 branches covered (71.68%)

Branch coverage included in aggregate %.

53 of 63 new or added lines in 7 files covered. (84.13%)

25197 of 29402 relevant lines covered (85.7%)

124.36 hits per line