dcdpr / jp / 28020439547

69%

push

github

chore(tools): Resolve revision before passing to `git blame` (#779)

`git blame` mishandles the `--end-of-options <rev> -- <path>` form: its
DWIM logic treats the first token after the consumed options as the `--`
position and shuffles the path into the revision slot, causing `fatal:
bad revision '<path>'` when an explicit revision and a path are both
supplied.

The tool now resolves the caller-supplied revision to a full 40-char SHA
via `git rev-parse --verify --end-of-options` before invoking blame.
Because `git rev-parse` honors `--end-of-options` correctly, an
option-shaped value like `--contents=/etc/passwd` is still treated as a
positional and fails revision resolution before blame is ever called. A
40-char hex SHA needs no `--end-of-options` guard, so the blame call is
simplified accordingly.

The original user-supplied ref is preserved in the rendered output so
`<revision>HEAD</revision>` still appears rather than the raw SHA.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

10 of 10 new or added lines in 1 file covered. (100.0%)

35736 of 53588 relevant lines covered (66.69%)

406.96 hits per line