ArduPilot / MethodicConfigurator / 28018491281

94%

push

github

fix: support tab- and space-separated param files in migration name parsing

_param_name_from_line only correctly extracted the parameter name
from comma-separated (Mission Planner style) .param file lines.

ParDict.load_param_file_into_dict supports three separator formats:
comma, space, and tab (mavproxy style). For tab- or space-separated
lines, _param_name_from_line returned the entire line, value
included, instead of just the parameter name.

This broke duplicate-parameter detection during vehicle project
migration: when merging extracted parameter lines into an existing
destination file, the same parameter at a different value in the
source and destination would not be recognized as a duplicate,
producing an invalid .param file with the parameter listed twice.
Loading such a file later raises ParamFileError(Duplicated parameter).

Fixed by detecting the separator (comma, space then tab, matching
the priority order used by ParDict.load_param_file_into_dict) before
splitting off the parameter name.

1998 of 2069 branches covered (96.57%)

12627 of 13374 relevant lines covered (94.41%)

2.82 hits per line