microlinkhq / browserless / 28009818944

81%

push

github

fix(lighthouse): retry context teardown masked as perf-mark error (#801)

When the browser context is torn down mid-run, lighthouse's marky teardown
calls performance.measure for a phase whose start mark never fired, throwing
`SyntaxError: The "start lh:…" performance mark has not been set`. That message
masks the real cause (a destroyed context), so it escaped the retry machinery
as an opaque error — surfacing as a misleading 500 and Sentry noise instead of
being retried.

Map the perf-mark error back to errors.contextDisconnected() so withPage
recreates the context and retries the run; persistent failures now surface as
EBRWSRCONTEXTCONNRESET (the accurate cause) rather than five phantom SyntaxError
groups.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

525 of 626 branches covered (83.87%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 1 file covered. (100.0%)

2498 of 2812 relevant lines covered (88.83%)

178177.83 hits per line