grpc
/
grpc-java
/
#20333
89%
|
Ran
|
Jobs
1
|
Files
658
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 88.871% (+0.005%) from 88.866%
push
github
web-flowUpgrade to Protobuf 35.1 (#12876) Per https://github.com/protocolbuffers/protobuf/releases ``` okshiva@okshiva-mac2 grpc-java % curl -sL https://github.com/protocolbuffers/protobuf/releases/download/v35.1/protobuf-35.1.tar.gz | shasum -a 256 f0b6838e7368f3024ac8fd03abd0a1ac4 ``` While upgrading Protobuf to 35.1, two secondary Bazel dependencies (`rules_proto` and `rules_android`) had to be addressed to keep the CI green. Here is the context: 1. Added `rules_proto` to `repositories.bzl` and `MODULE.bazel`. The googleapis dependency requires `rules_proto` to build. During the CI job (--enable_bzlmod=false), the build failed during the analysis phase because googleapis could no longer implicitly fetch `rules_proto` via Protobuf. 2. Upgraded to rules_android v0.7.3 Previous version of `rules_android` (v0.7.2) explicitly hardcoded "`com.google.protobuf:protobuf-java:4.33.4`" in its internal maven artifacts. During the Android CI job, Bazel used our newly upgraded 35.1 compiler to generate internal Android resource files (gencode 4.35.1). However, because `rules_android`'s internal tools (like `ResourceProcessorBusyBox`) were locked to the 4.33.4 runtime, it triggered a `ProtobufRuntimeVersionException` (poison pill).
36525 of 41099 relevant lines covered (88.87%)
0.89 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 3 |
90.63 |
-0.59% | ../netty/src/main/java/io/grpc/netty/NettyServerHandler.java |
| 2 |
90.56 |
-0.7% | ../core/src/main/java/io/grpc/internal/DelayedClientCall.java |
| 1 |
93.21 |
-0.14% | ../okhttp/src/main/java/io/grpc/okhttp/OkHttpClientTransport.java |
| 1 |
93.83 |
-0.62% | ../opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricSink.java |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | #20333.1 | 658 |
88.87 |
