sds / haml-lint / 28000422921

97%

Build Type

push

github

Committed by web-flow

Commit Message

Fix LineLength not being disabled inside filter blocks (#658)

A `haml-lint:disable LineLength` comment had no effect on long lines
inside filter blocks such as `:javascript` or `:css`.

`Linter::LineLength` resolves each over-long line to its owning node via
`RootNode#node_for_line` and checks the directive chain on that node. A
`FilterNode` sits on the `:filtername` declaration line while its content
lives on the following lines, but the base `Node#line_numbers` assumed the
text started on the node's own line. The filter's content lines were
therefore left uncovered, so `node_for_line` fell through to a `NullNode`
(which carries no directives) and the disable comment was silently lost.

Override `line_numbers` in `FilterNode` so its span covers the declaration
line plus all of its indented content lines.

Fixes #623

Co-authored-by: Shane da Silva <shane@dasilva.io>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

3028 of 3110 relevant lines covered (97.36%)

23037.95 hits per line