sds / haml-lint / 28000318654

97%

push

github

Fix false UselessAssignment for HTML-style (parens) attributes (#659)

HTML-style attributes like `%div(foo=foo)` are handed to the Ruby
extractor as a synthesized hash string (e.g. `{"foo" => foo,}`). Because
that text isn't present verbatim in the HAML, it can't be mapped back for
auto-correct, so the extractor was discarding it entirely. As a result,
variables used only inside parens attributes were invisible to RuboCop,
which reported a false `Lint/UselessAssignment` and, on auto-correct,
removed the assignment, breaking the rendered output.

Extract just the attribute value expressions and emit them as a
non-correctable chunk (`HL.out = <value>`) so RuboCop sees the variables
being used. Auto-correct of parens attributes remains intentionally
unsupported.

Fixes #648

Co-authored-by: Shane da Silva <shane@dasilva.io>

10 of 10 new or added lines in 1 file covered. (100.0%)

3026 of 3107 relevant lines covered (97.39%)

23027.8 hits per line