kobotoolbox / kpi / 27980592878

81%

master: 76%

push

github

fix(map): include start-geopoint in Project → Data → Map UI DEV-2240 (#7136)

### 📣 Summary

Map now shows submissions that only have `start-geopoint` data. Before
this, the map stayed empty if your project collected locations via
`start-geopoint` but didn't have any geopoint questions.

### 💭 Notes

Changes here:

**`constants.ts`**
- Added `MAP_DISPLAYABLE_GEOPOINT_TYPES` array that includes both
`'geopoint'` and `'start-geopoint'` question types
- Added `isMapDisplayableGeopointType()` type guard function to check if
a question type can be shown on the map
- This gives us a single place to define which question types the map
should recognize (easier to maintain if we add more geo types later,
like `'background-geopoint'`)

**`utils.ts`**
- Updated `findFirstGeopoint()` to use the new type guard instead of
only checking for `'geopoint'`
- Now finds either regular geopoint questions or start-geopoint

**`components/map/index.tsx`** (the main map component)
- Constructor now uses `isMapDisplayableGeopointType()` to check if the
project has any map-compatible questions
- This fixes the "no geopoint responses" message showing up when
start-geopoint data actually exists

**components/map/FormMapWrapper.stories.tsx:**
- New Storybook stories with play tests that verify:
  - Map renders for forms with only start-geopoint
  - Map Settings shows both geopoint and start-geopoint when both exist

**.storybook/preview-head.html**
- Mock `window.t()` before modules load (fixes "t is not defined" errors
when components use t() at module scope), as `preview.tsx` `t()`
definition wasn't working

**`components/map/MapSettings.tsx`** (the map settings dialog)
- Updated to include start-geopoint questions in the question selector
dropdown
- Without this, users couldn't manually switch to start-geopoint even if
it had data

**storybookUtils.tsx**
- New `withMinHeightWrapper()` decorator for stories that need vertical
space (maps, menus, modals)
- Updated `Menu.stories.... (continued)

9064 of 12305 branches covered (73.66%)

29791 of 36506 relevant lines covered (81.61%)

5.56 hits per line