decentraland / asset-bundle-registry / 27971581861

71%

main: 72%

Pull #126

github

refactor: migrate to @dcl core-components and core-libs packages

migrate the service off @well-known-components/* (and the node-fetch-typed
@dcl/http-server v1) onto the native-fetch @dcl core-components / core-libs stack:

- http-server v1 -> @dcl/http-server v2 (IHttpServerComponent now native, from @dcl/core-commons)
- fetch-component -> @dcl/fetch-component (native fetch)
- features-component -> @dcl/features-component
- metrics -> @dcl/metrics
- test-helpers (dev) -> @dcl/test-helpers
- platform-crypto-middleware -> @dcl/crypto-middleware ^4.0.0 (core-libs, native; wellKnownComponents,
  DecentralandSignatureContext, AUTH_* headers). v4 drops the passport strategy that v3 eagerly
  required, so no passport-strategy runtime dependency is needed.
- http-commons v1 -> v2 (native errorHandler / bearerTokenMiddleware)

native fetch propagation: IFetchComponent and IHttpServerComponent are re-sourced from
@dcl/core-commons in src/types/system.ts, which flows through every handler via
HandlerContextWithPath. catalyst.ts RequestOptions also moves to core-commons.

other adjustments:
- bump dcl-catalyst-client 21 -> 22 (native fetch; downloadContent now returns Uint8Array,
  decoded via Buffer.from)
- bump @well-known-components/interfaces to ^1.5.2 (single resolved version; symbol lifecycle)
- add jest, ts-jest and @types/jest as explicit devDependencies (previously transitive via
  @well-known-components/test-helpers; @dcl/test-helpers declares jest as a peer)
- @dcl/snapshots-fetcher has no native build yet, so the app's native fetch is cast to the
  node-fetch IFetchComponent at the single call site that passes it (runtime-safe: it only
  calls fetcher.fetch(urlString, opts))

env-config-provider, logger and interfaces stay on @well-known-components as they have no
core-components equivalent yet.

629 of 920 branches covered (68.37%)

Branch coverage included in aggregate %.

6 of 8 new or added lines in 6 files covered. (75.0%)

1632 of 2249 relevant lines covered (72.57%)

40.08 hits per line