PrincetonUniversity / PsyNeuLink / 27966968306

84%

master: 85%

Build Type

push

github

Committed by davidt0x

Commit Message

Fix PEC degenerate-likelihood warning re-printing stale parameter sets

The optimizer callback summarized degenerate objective-function warnings from
a warns_with_params list that was never cleared, so each iteration/trial
re-printed every degenerate parameter set seen since the search began. This
pinned the first bad set to the top of the log on every subsequent callback,
even though it was not just evaluated, and cluttered the output.

Extract the summary logic into _report_degenerate_warnings, which clears the
accumulated warnings after printing so each callback only reports sets that
went degenerate since the last callback. Also always clear the per-eval warns
buffer (previously only cleared inside the display_iter branch) so a stale
warns[-1] cannot be mis-attributed to a later, possibly warning-free,
parameter set. Fixes a missing space in the footer text.

Add a regression test covering the cleared-between-callbacks behavior.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

11020 of 14380 branches covered (76.63%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

37663 of 43558 relevant lines covered (86.47%)

0.86 hits per line