decentraland / events / 27968684486

65%

push

github

refactor: drop node-fetch in favor of native fetch (#957)

* refactor: drop node-fetch in favor of native fetch

replace direct node-fetch usage with node's built-in fetch and bump the
catalyst client so it no longer drags node-fetch in.

- bin/smokeTest: `timeout` option -> `AbortSignal.timeout`, type `init` as `RequestInit`
- scripts/test-update-event-auth: drop the node-fetch import; read the network
  error code from `error.cause` (native fetch wraps failures as `TypeError`)
- bump dcl-catalyst-client ^21.5.0 -> ^22.0.0, which swaps cross-fetch (node-fetch)
  for @dcl/fetch-component (native fetch via @dcl/core-commons); the
  contracts-snapshots `cache` shape used by src/modules/servers.ts is unchanged

node-fetch stays in the tree transitively (decentraland-gatsby, sequence, segment);
this removes our direct usage and one transitive path.

* chore: bump decentraland-gatsby to 8.4.5

8.4.5 is the first release where decentraland-gatsby uses native fetch internally
(@dcl/http-server + @dcl/crypto-middleware instead of well-known-components
http-server + decentraland-crypto-middleware), so this drops the node-fetch paths
that gatsby was contributing to the dependency tree.

* style: apply prettier formatting to test-update-event-auth script

CI's lint-action runs prettier across the whole repo (ts/js/json/md/...), not
just src/ like the local `npm run lint` (eslint --ext .ts,.js ./src), so it
flagged scripts/test-update-event-auth.ts. Prettier only removed redundant
parens around the `??` expression (??  binds tighter than ?:, so semantics are
unchanged).

573 of 800 branches covered (71.63%)

Branch coverage included in aggregate %.

3511 of 5491 relevant lines covered (63.94%)

5.49 hits per line